Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix libvirt_ap_passthrough_autostart failure due to incorrectly string #5955

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix libvirt_ap_passthrough_autostart failure due to incorrectly string #5955

merged 1 commit into from
Oct 23, 2024

Conversation

chunfuwen
Copy link
Contributor

Fix libvirt_ap_passthrough_autostart failure due to incorrectly string format in LOG.debug

Typically, it will throw TypeError: not all arguments converted during string formatting

@chunfuwen
Fix libvirt_ap_passthrough_autostart failure due to incorrectly string
101b75f 
format in LOG.debug

Typically, it will throw TypeError: not all arguments converted during string formatting

Signed-off-by: chunfuwen <[email protected]>
@chunfuwen
Copy link
Contributor Author

chunfuwen commented Oct 23, 2024 •
edited
Loading

previously failure:

2024-10-22 14:22:49,971 avocado.test stacktrace L0042 ERROR| Reproduced traceback from: /var/ci/libvirt-ci/runtest/avocado-vt/avocado-vt/avocado_vt/test.py:298
2024-10-22 14:22:49,979 avocado.test stacktrace L0049 ERROR| Traceback (most recent call last):
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| File "/var/lib/avocado/data/avocado-vt/virttest/test-providers.d/downloads/io-github-autotest-libvirt/libvirt/tests/src/passthrough/ap/libvirt_ap_passthrough_autostart.py", line 74, in run
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| confirm_device_is_running(uuid, session)
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| File "/var/lib/avocado/data/avocado-vt/virttest/test-providers.d/downloads/io-github-autotest-libvirt/libvirt/tests/src/passthrough/ap/libvirt_ap_passthrough_autostart.py", line 43, in confirm_device_is_running
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| if not wait_for(_is_listed, timeout=5):
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| File "/var/ci/libvirt-ci/runtest/avocado-vt/avocado-vt/virttest/utils_misc.py", line 581, in wait_for
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| output = func()
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| File "/var/lib/avocado/data/avocado-vt/virttest/test-providers.d/downloads/io-github-autotest-libvirt/libvirt/tests/src/passthrough/ap/libvirt_ap_passthrough_autostart.py", line 41, in _is_listed
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| LOG.debug(err, out)
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| File "/usr/lib64/python3.9/logging/init.py", line 1434, in debug
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| self._log(DEBUG, msg, args, **kwargs)
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| File "/usr/lib64/python3.9/logging/init.py", line 1589, in _log
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| self.handle(record)
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| File "/usr/lib64/python3.9/logging/init.py", line 1599, in handle
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| self.callHandlers(record)
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| File "/usr/lib64/python3.9/logging/init.py", line 1661, in callHandlers
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| hdlr.handle(record)
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| File "/usr/lib64/python3.9/logging/init.py", line 952, in handle
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| self.emit(record)
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| File "/var/ci/libvirt-ci/runtest/avocado-vt/avocado/avocado/core/utils/messages.py", line 199, in emit
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| msg = self.format(record)
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| File "/usr/lib64/python3.9/logging/init.py", line 927, in format
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| return fmt.format(record)
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| File "/usr/lib64/python3.9/logging/init.py", line 663, in format
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| record.message = record.getMessage()
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| File "/usr/lib64/python3.9/logging/init.py", line 367, in getMessage
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| msg = msg % self.args
2024-10-22 14:22:49,980 avocado.test stacktrace L0049 ERROR| TypeError: not all arguments converted during string formatting

@chunfuwen
Copy link
Contributor Author

@smitterl , please take a look

smitterl
smitterl approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@smitterl smitterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@smitterl smitterl mentioned this pull request Oct 23, 2024
Closed
@chunfuwen
Copy link
Contributor Author

'status': 'finished', 'time': 2061.110304061}"
2024-10-23 04:20:48,564 avocado.app human L0129 DEBUG| (1/1) type_specific.io-github-autotest-libvirt.libvirt_ap_passthrough.autostart:
2024-10-23 04:20:48,564 avocado.app human L0136 DEBUG| PASS (55.18 s)
2024-10-23 04:20:48,567 avocado.job testlogs L0138 INFO | type_specific.io-github-autotest-libvirt.libvirt_ap_passthrough.autostart: PASS
2024-10-23 04:20:48,567 avocado.job testlogs L0139 INFO | More information in /var/log/avocado/job-results/job-2024-10-23T04.19-d418496/test-results/1-type_specific.io-github-autotest-libvirt.libvirt_ap_passthrough.autostart
2024-10-23 04:20:48,567 avocado.core.task.statemachine statemachine L0146

@chunfuwen chunfuwen merged commit ccbef63 into autotest:master Oct 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitterl smitterl smitterl approved these changes

@cliping cliping cliping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chunfuwen @cliping @smitterl